Horton

Re: POC: Sharing record typmods between backends

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-08-24T12:08:08Z
Lists: pgsql-hackers

Attachments

On Wed, Aug 23, 2017 at 11:58 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Wed, Aug 23, 2017 at 5:46 PM, Andres Freund <andres@anarazel.de> wrote:
>> Notes for possible followup commits of the dshash API:
>> - nontrivial portions of dsahash are essentially critical sections lest
>>   dynamic shared memory is leaked. Should we, short term, introduce
>>   actual critical section markers to make that more obvious? Should we,
>>   longer term, make this more failsafe / easier to use, by
>>   extending/emulating memory contexts for dsa memory?
>
> Hmm.  I will look into this.

Yeah, dshash_create() leaks the control object if the later allocation
of the initial hash table array raises an error.  I think that should
be fixed -- please see 0001 in the new patch set attached.

The other two places where shared memory is allocated are resize() and
insert_into_bucket(), and both of those seem exception-safe to me: if
dsa_allocate() elogs then nothing is changed, and the code after that
point is no-throw.  Am I missing something?

>> - SharedRecordTypmodRegistryInit() is called from GetSessionDsmHandle()
>>   which calls EnsureCurrentSession(), but
>>   SharedRecordTypmodRegistryInit() does so again - sprinkling those
>>   around liberally seems like it could hide bugs.
>
> Yeah.  Will look into this.

One idea is to run InitializeSession() in InitPostgres() instead, so
that CurrentSession is initialized at startup, but initially empty.
See attached.  (I realised that that terminology is a bit like a large
volume called FRENCH CUISINE which turns out to have just one recipe
for an omelette in it, but you have to start somewhere...)  Better
ideas?

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Remove TupleDesc remapping logic from tqueue.c.

  2. Add support for coordinating record typmods among parallel workers.

  3. Improve division of labor between execParallel.c and nodeGather[Merge].c.

  4. Add minimal regression test for blessed record type transfer.

  5. Consolidate the function pointer types used by dshash.c.

  6. Fix unlikely shared memory leak after failure in dshash_create().

  7. Refactor typcache.c's record typmod hash table.

  8. Add a hash_combine function for mixing hash values.

  9. Backpatch introduction of TupleDescAttr(tupdesc, i).

  10. Partially flatten struct tupleDesc so that it can be used in DSM.

  11. Change tupledesc->attrs[n] to TupleDescAttr(tupledesc, n).