Re: pread() and pwrite()

Thomas Munro <thomas.munro@enterprisedb.com>

From: Thomas Munro <thomas.munro@enterprisedb.com>

To: Jesper Pedersen <jesper.pedersen@redhat.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>, Oskari Saarenmaa <os@ohmu.fi>, Pg Hackers <pgsql-hackers@postgresql.org>, Tobias Oberstein <tobias.oberstein@gmail.com>

Date: 2018-11-03T11:03:06Z

Lists: pgsql-hackers

Attachments

0001-Use-pread-pwrite-instead-of-lseek-read-write-v8.patch (application/octet-stream) patch v8-0001
0002-Supply-pread-pwrite-implementations-for-Windows-v8.patch (application/octet-stream) patch v8-0002

On Sat, Nov 3, 2018 at 2:07 AM Jesper Pedersen
<jesper.pedersen@redhat.com> wrote:
> This still applies, and passes make check-world.
>
> I wonder what the commit policy is on this, if the Windows part isn't
> included. I read Heikki's comment [1] as it would be ok to commit
> benefiting all platforms that has pread/pwrite.

Here's a patch to add Windows support by supplying
src/backend/port/win32/pread.c.  Thoughts?

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

Use pg_pread() and pg_pwrite() for data files and WAL.
- c24dcd0cfd94 12.0 landed
Provide pg_pread() and pg_pwrite() for random I/O.
- 3fd2a7932ef0 12.0 landed
Convert some long lists in configure.in to one-line-per-entry style.
- bfa6c5a0c974 12.0 landed