Horton

Re: BUG #15347: Unaccent for greek characters does not work

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Tasos Maschalidis <TaS.O.S@hotmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2018-08-27T22:50:38Z
Lists: pgsql-bugs

Attachments

On Fri, Aug 24, 2018 at 11:35 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Aug 24, 2018 at 03:32:28PM +1200, Thomas Munro wrote:
> Thanks for considering it.  I have not gone in details through the patch
> but...
>
> +           (codepoint.id >= ord('A') and codepoint.id <= ord('Z')) or \
> +           (codepoint.id >= 0x03b1 and codepoint.id <= 0x03c9) or \
> +           (codepoint.id >= 0x0391 and codepoint.id <= 0x03a9)
>
> ...  If you could add notes about what those codepoints are, or just
> allocate them in a variable with a proper name, that would help with the
> readability.  My apologies for the nits on this thread.

Fair criticism, here's a version with comments.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Add Greek characters to unaccent.rules.