Horton

Re: BUG #15548: Unaccent does not remove combining diacritical characters

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Hugh Ranalli <hugh@whtc.ca>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Daniel Verite <daniel@manitou-mail.org>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-01-28T07:26:29Z
Lists: pgsql-bugs, pgsql-hackers 
On Mon, Jan 28, 2019 at 7:45 PM Michael Paquier <michael@paquier.xyz> wrote:
> You are registered as a reviewer and committer of the last patch of
> this thread:
> https://commitfest.postgresql.org/21/1924/
>
> Are you planning to look at it or should I jump in?  I have not looked
> at the patch status in depth yet.

Thanks for the reminder.  I looked at this a couple of weeks ago when
you ping me off-list, but I see we're still waiting for a rebase.
Hugh, can you please post a new patch?  The approach looks right to me
(simply replace the composing diacritics with nothing), so if you post
a new version I'll  double check with that test case I came up with
earlier, and then I'll be happy to commit it.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Fix unaccent generation script in Windows

  2. Add combining characters to unaccent.rules.

  3. Update unaccent rules with release 34 of CLDR for Latin-ASCII.xml

  4. unaccent: Make generate_unaccent_rules.py Python 3 compatible

  5. Convert unaccent tests to UTF-8