TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es

From: Thomas Munro <thomas.munro@enterprisedb.com>

To: Pg Hackers <pgsql-hackers@postgresql.org>

Cc: Andres Freund <andres@anarazel.de>, Andrew Gierth <andrew@tao11.riddles.org.uk>

Date: 2017-11-29T07:58:25Z

Lists: pgsql-hackers

Attachments

fix-TupleDescCopy-v1.patch (application/octet-stream) patch v1

Hi hackers,

Andrew Gierth complained off-list that TupleDescCopy() doesn't clear
atthasdef.  Yeah, that's an oversight.  The function is new in commit
cc5f81366c36 and was written by me to support "flat" (pointer-free)
tuple descriptors for use in DSM.  Following the example of
CreateTupleDescCopy() I think it should also clear attnotnull and
attidentity.  Please see attached.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

Clean up tupdesc.c for recent changes.
- 47c6772eb722 11.0 landed
Add support for coordinating record typmods among parallel workers.
- cc5f81366c36 11.0 cited