Horton

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Paul Guo <paulguo@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Richard Guo <guofenglinux@gmail.com>
Date: 2018-07-30T01:38:18Z
Lists: pgsql-hackers 
On Thu, May 17, 2018 at 8:20 PM, Paul Guo <paulguo@gmail.com> wrote:
> Thanks. I tentatively submitted a patch (See the attachment).

Hi Paul,

It looks like you missed a couple of changes in the contrib/btree_gist
bit and varbit tests, so make check-world fails:

- Index Cond: ((a >= B'1000000'::"bit") AND (a <= B'1000001'::"bit"))
+ Index Cond: ((a >= '1000000'::"bit") AND (a <= '1000001'::"bit"))

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Remove ruleutils.c's special case for BIT [VARYING] literals.

  2. Make pg_dump output more portable and more pleasing to look at.