Horton

Re: Refactor handling of database attributes between pg_dump and pg_dumpall

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Andreas Karlsson <andreas@proxel.se>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-09-08T00:24:17Z
Lists: pgsql-hackers 
On Mon, Aug 21, 2017 at 4:35 PM, Haribabu Kommi
<kommi.haribabu@gmail.com> wrote:
> On Tue, Aug 15, 2017 at 7:29 AM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> On 4/4/17 01:06, Haribabu Kommi wrote:
>> > Both pg_dump and pg_upgrade tests are passed. Updated patch attached
>> > I will add this patch to the next commitfest.
>>
>> This patch needs to be rebased for the upcoming commit fest.
>
> Thanks for checking. Rebased patch is attached.

Hi Haribabu,

This patch breaks the documentation build, possibly because of these empty tags:

+        <option>--create</option> option to dump <>ALTER ROLE IN
DATABASE ... SET</>

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Move handling of database properties from pg_dumpall into pg_dump.

  2. Allow pg_dumpall to dump roles w/o user passwords

  3. Fix pg_dumpall to work for databases flagged as read-only.