Horton

Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, Andrew Gierth <andrew@tao11.riddles.org.uk>
Date: 2018-01-03T23:31:41Z
Lists: pgsql-hackers 
On Thu, Jan 4, 2018 at 12:29 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> If there is any system where sizeof(FormData_pg_attribute) !=
> (offsetof(FormData_pg_attribute,attcollation) + sizeof(Oid)), won't
> load_relcache_init_file() get upset?  Oh, I see it would just go to
> read_failed and then "do it the hard way".

This doesn't make any sense, we're free to change that file format in
a major release anyway.  I withdraw that comment!

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Clean up tupdesc.c for recent changes.

  2. Add support for coordinating record typmods among parallel workers.