Horton

Re: Enhanced error message to include hint messages for redundant options error

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread View on postgr.es
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2021-07-11T09:52:56Z
Lists: pgsql-hackers 
On Sat, 10 Jul 2021 at 18:09, vignesh C <vignesh21@gmail.com> wrote:
>
> I'm planning to handle conflicting errors separately after this
> current work is done, once the patch is changed to have just the valid
> scenarios(removing the scenarios you have pointed out)  existing
> function can work as is without any changes. Thoughts?

Ah OK, that might be reasonable. Perhaps, then errorDuplicateDefElem()
and errorConflictingDefElem() would be better than what I originally
suggested.

BTW, another case I spotted was this:

copy (select 1) to stdout csv csv header;
ERROR:  option "format" specified more than once
LINE 1: copy (select 1) to stdout csv csv header;
                                      ^

which isn't good because there is no option called "format".

Regards,
Dean

Commits

  1. Improve reporting of "conflicting or redundant options" errors.

  2. Refactor function parse_subscription_options.