Re: Proof of concept: auto updatable views [Review of Patch]
Dean Rasheed <dean.a.rasheed@gmail.com>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thom Brown <thom@linux.com>, Peter Eisentraut <peter_e@gmx.net>, Amit kapila <amit.kapila@huawei.com>, "robertmhaas@gmail.com" <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2012-12-09T22:13:27Z
Lists: pgsql-hackers
On 9 December 2012 22:00, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Dean Rasheed <dean.a.rasheed@gmail.com> writes: >> It's a shame though that pg_view_is_updatable() and >> pg_view_is_insertable() are not really useful for identifying >> potentially updatable views (e.g., consider an auto-updatable view on >> top of a trigger-updatable view). I'm left wondering if I >> misinterpreted the SQL standard's intentions when separating out the >> concepts of "updatable" and "trigger updatable". It seems like it >> would have been more useful to have "trigger updatable" imply >> "updatable". > > I wondered about that too, but concluded that they were separate after > noticing that the standard frequently writes things like "updatable or > trigger updatable". They wouldn't need to write that if the latter > implied the former. > Yeah, that was my reasoning too. > But in any case, those functions are expensive enough that I can't see > running them against every view in the DB anytime somebody hits tab. > I think just allowing tab-completion to include all views is probably > the best compromise. > Agreed. Regards, Dean