Re: Multivariate MCV stats can leak data to unprivileged users
Dean Rasheed <dean.a.rasheed@gmail.com>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-05-18T09:11:58Z
Lists: pgsql-hackers
On Fri, 17 May 2019 at 21:29, Andres Freund <andres@anarazel.de> wrote: > > On 2019-05-16 14:28:03 +0100, Dean Rasheed wrote: > > 5). Some columns from pg_statistic_ext have to be made visible for > > psql \d to work. Basically, it needs to be able to query for the > > existence of extended statistics, but it doesn't need to see the > > actual statistical data. Of course, we could change psql to use the > > view, but this way gives us better backwards compatibility with older > > clients. > > > > This is still going to break compatibility of any user code looking at > > stxndistinct or stxdependencies from pg_statistic_ext, but at least it > > doesn't break old versions of psql. > > Hm, it's not normally a goal to keep old psql working against new > postgres versions. And there's plenty other issues preventing a v11 psql > to work against 12. I'd not let this guide any design decisions. > Ah good point. In fact running "\d some_table" from v11's psql against a v12 database immediately falls over because of the removal of relhasoids from pg_class, so this isn't a valid reason for retaining access to any columns from pg_statistic_ext. Regards, Dean
Commits
-
Add security checks to the multivariate MCV estimation code.
- d7f8d26d9f4c 12.0 landed
-
Add pg_stats_ext view for extended statistics
- aa087ec64f70 12.0 landed
-
Rework the pg_statistic_ext catalog
- 6cbfb784c3c9 12.0 landed