Horton

Re: psql :: support for \ev viewname and \sv viewname

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread View on postgr.es
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Petr Korobeinikov <pkorobeinikov@gmail.com>, Jeevan Chalke <jeevan.chalke@enterprisedb.com>, Jeevan Chalke <jeevan.chalke@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2015-07-22T20:32:38Z
Lists: pgsql-hackers 
On 3 July 2015 at 20:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Petr Korobeinikov <pkorobeinikov@gmail.com> writes:
>> Fixed. Now both \ev and \sv  numbering lines starting with "1". New version
>> attached.
>
> Applied with a fair amount of mostly-cosmetic adjustment.
>
>> As I've already noticed that pg_get_viewdef() does not support full syntax
>> of creating or replacing views.
>
> Oh?  If that were true, pg_dump wouldn't work on such views.  It is kind
> of a PITA for this purpose that it doesn't include the CREATE text for
> you, but we're surely not changing that behavior now.
>

This appears to be missing support for view options (WITH CHECK OPTION
and security_barrier), so editing a view with either of those options
will cause them to be stripped off.

Regards,
Dean

Commits

  1. Fix psql's \ev and \sv commands so that they handle view reloptions.

  2. Move and rename fmtReloptionsArray().

  3. pgindent run for 9.5