Horton

Re: psql :: support for \ev viewname and \sv viewname

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread View on postgr.es
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Petr Korobeinikov <pkorobeinikov@gmail.com>, Jeevan Chalke <jeevan.chalke@enterprisedb.com>, Jeevan Chalke <jeevan.chalke@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2016-05-06T12:30:31Z
Lists: pgsql-hackers 
On 4 May 2016 at 13:23, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 5/4/16 3:21 AM, Dean Rasheed wrote:
>> Well, appendStringLiteralAH() takes both, so that sets a precedent.
> Works for me.  Could you supply an updated patch with a static function
> instead of a macro?  Then I think this is good to go.
>
> (bonus points for some tests)
>

OK, pushed that way.

I didn't get round to adding any tests though. I strikes me that the
most likely bugs in this area are bugs of omission, like this and the
missing PARALLEL SAFE recently fixed for functions. Ideally tests
would be able to spot those kinds of issues, but it's not obvious how
to write such tests.

Regards,
Dean

Commits

  1. Fix psql's \ev and \sv commands so that they handle view reloptions.

  2. Move and rename fmtReloptionsArray().

  3. pgindent run for 9.5