Horton

Thread

Commits

  1. Fix typo in create_index.sql.

  1. Typo in create_index regression test

    Dean Rasheed <dean.a.rasheed@gmail.com> — 2025-08-04T14:10:23Z

    While looking at create_index.sql, I noticed the following:

--
-- Check handling of indexes on system columns
--
CREATE TABLE syscol_table (a INT);

-- System columns cannot be indexed
CREATE INDEX ON syscolcol_table (ctid);

which isn't testing what it claims to test because there's a typo in
the table name. Patch attached.

Regards,
Dean

  2. Re: Typo in create_index regression test

    Tender Wang <tndrwang@gmail.com> — 2025-08-04T14:18:38Z

    Dean Rasheed <dean.a.rasheed@gmail.com> 于2025年8月4日周一 22:10写道：

> While looking at create_index.sql, I noticed the following:
>
> --
> -- Check handling of indexes on system columns
> --
> CREATE TABLE syscol_table (a INT);
>
> -- System columns cannot be indexed
> CREATE INDEX ON syscolcol_table (ctid);
>
> which isn't testing what it claims to test because there's a typo in
> the table name. Patch attached.
>

Good catch.
LGTM.

-- 
Thanks,
Tender Wang

  3. Re: Typo in create_index regression test

    Dean Rasheed <dean.a.rasheed@gmail.com> — 2025-08-04T15:47:37Z

    On Mon, 4 Aug 2025 at 15:18, Tender Wang <tndrwang@gmail.com> wrote:
>
> Dean Rasheed <dean.a.rasheed@gmail.com> 于2025年8月4日周一 22:10写道：
>>
>> While looking at create_index.sql, I noticed the following:
>>
>> which isn't testing what it claims to test because there's a typo in
>> the table name. Patch attached.
>
> Good catch.
> LGTM.

Pushed. Thanks for looking.

Regards,
Dean