Re: ON CONFLICT DO SELECT (take 3)
Dean Rasheed <dean.a.rasheed@gmail.com>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: "v@viktorh.net" <v@viktorh.net>
Cc: jian he <jian.universality@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-11-19T14:08:14Z
Lists: pgsql-hackers
Attachments
- v12-0001-Add-support-for-INSERT-.-ON-CONFLICT-DO-SELECT.patch (text/x-patch)
- v12-0002-More-suggested-review-comments.patch (text/x-patch)
On Mon, 17 Nov 2025 at 22:07, v@viktorh.net <v@viktorh.net> wrote: > > I believe this new patch addresses all the issues found by Jian. I hope another review won’t find quite so much dirt! > The latest set of changes look reasonable to me, so I've squashed those 2 commits together and made an initial stab at writing a more complete commit message. I made a quick pass over the code, and I'm attaching a few more suggested updates. This is mostly cosmetic stuff (e.g., fixing a few code comments that were overlooked), plus some minor refactoring to reduce code duplication. Regards, Dean