Horton

Re: ON CONFLICT DO SELECT (take 3)

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Viktor Holmberg <v@viktorh.net>
Cc: jian he <jian.universality@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-11-19T17:19:35Z
Lists: pgsql-hackers 
On Wed, 19 Nov 2025 at 16:51, Viktor Holmberg <v@viktorh.net> wrote:
>
> For the CASE default, elog(ERROR, "unrecognized LockClauseStrength %d” that was removed.
> Would this now trigger a compile time error/warning? And are you supposed to get 0 warnings when compiling?

That shouldn't trigger a warning, because there is a case block for
every enum element, and yes there should be 0 compiler warnings.

> (I get a large amount of warnings "warning: 'pg_restrict' macro redefined" on master, but that could just be something with my environment)

I haven't seen that before, but there's this thread:

https://www.postgresql.org/message-id/flat/CA%2BFpmFdoa7O7yS3k7ZtqvA%2BhNWUA6YvJy6VvdYX1sGsryVQBNQ%40mail.gmail.com

If you re-run configure, does it go away?

Regards,
Dean