Horton

Re: Foreign key isolation tests

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread View on postgr.es
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Paul Jungwirth <pj@illuminatedcomputing.com>
Cc: Rustam ALLAKOV <rustamallakov@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-07-18T10:29:44Z
Lists: pgsql-hackers 
On Fri, 11 Jul 2025 at 23:22, Paul Jungwirth
<pj@illuminatedcomputing.com> wrote:
>
> On 7/11/25 11:50, Rustam ALLAKOV wrote:
> > Hi Paul,
> > Thanks for this patch!
> > Lilian and I have reviewed your patches.
>
> Thank you for the review! I've attached new patches addressing your feedback.
>

I agree that additional testing in this area is valuable. Patch 0001
looks reasonable to me, on a quick read-through. In patch 0002, I
think it would be valuable to also test updating the parent row to
time periods consistent and not consistent with the insert, to confirm
that that behaves correctly.

Regards,
Dean

Commits

  1. Improve comment about snapshot macros

  2. Add test for temporal referential integrity

  3. Fill testing gap for possible referential integrity violation

  4. Simplify COALESCE() with one surviving argument.