Horton

Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Kirill Reshke <reshkekirill@gmail.com>, Joel Jacobson <joel@compiler.org>, pgsql-hackers <pgsql-hackers@postgresql.org>, Marko Tiikkaja <marko@joh.to>
Date: 2025-06-25T11:39:08Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add support for INSERT ... ON CONFLICT DO SELECT.

On Mon, 12 May 2025 at 19:33, Andreas Karlsson <andreas@proxel.se> wrote:
>
> I have fixed that one and some other issues locally and will submit a
> new version in a while after I have added more tests because you are
> very correct in that a big issue with my last version of the patch was
> the big lack of tests and lack of making sure all features which
> interact with UPSERT actually worked with my changes. Plus some islation
> tests would be nice to have.
>

+1. Don't forget to move the CF entry to the next open CF.

FYI, over on [1] I proposed more tests and doc updates for RLS. I
think those updates might make it easier to test and document the RLS
aspects of this patch.

[1] https://www.postgresql.org/message-id/flat/CAEZATCWqnfeChjK=n1V_dYZT4rt4mnq+ybf9c0qXDYTVMsy8pg@mail.gmail.com

Regards,
Dean