Horton

Re: Minor fixes for couple some comments around MERGE RETURNING

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread View on postgr.es
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2024-06-04T08:39:05Z
Lists: pgsql-hackers 
On Thu, 23 May 2024 at 04:26, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Sun, 19 May 2024 at 15:20, David Rowley <dgrowleyml@gmail.com> wrote:
> >
> > I noticed that PlannedStmt.hasReturning and hasModifyingCTE have an
> > outdated comment now that MERGE supports RETURNING (per commit
> > c649fa24a)
> >
> > i.e. these two:
> >
> > > bool hasReturning; /* is it insert|update|delete RETURNING? */
> >
> > > bool hasModifyingCTE; /* has insert|update|delete in WITH? */
>
> I've pushed the fix for that.
>

Thanks for taking care of that.

I found another couple of similar comments that also needed updating,
so I've pushed a fix for them too.

Regards,
Dean

Commits

  1. Fix another couple of outdated comments for MERGE RETURNING.

  2. Fix a couple of outdated comments now that we have MERGE RETURNING

  3. Add RETURNING support to MERGE.