Re: Does rewriteTargetListIU still need to add UPDATE tlist entries?
Dean Rasheed <dean.a.rasheed@gmail.com>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-26T14:27:59Z
Lists: pgsql-hackers
On Mon, 26 Apr 2021 at 15:09, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Thanks for looking at that. On reflection I think this must be so, > because those rewriter mechanisms were designed long before we had > trigger-updatable views, and rewriteTargetListIU has never added > tlist items like this for any other sort of view. So the ability > to insert the original view output column has necessarily been there > from the beginning. This is just getting rid of a weird implementation > difference between trigger-updatable views and other views. > FWIW, I had a look at this too and came to much the same conclusion, so I think this is a safe change that makes the code a little neater and more efficient. Regards, Dean
Commits
-
Remove rewriteTargetListIU's expansion of view targetlists in UPDATE.
- 04942bffd0aa 14.0 landed