Re: factorial of negative numbers
Dean Rasheed <dean.a.rasheed@gmail.com>
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-06-16T07:31:21Z
Lists: pgsql-hackers
On Tue, 16 Jun 2020 at 06:00, Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com> wrote: > > Divison by zero is really undefined, 12345678 * 12345678 (just some numbers) is out of range of say int4, but factorial of a negative number has some meaning and is defined but PostgreSQL does not support it. > Actually, I think undefined/out-of-range is the right error to throw here. Most common implementations do regard factorial as undefined for anything other than positive integers, as well as following the convention that factorial(0) = 1. Some implementations extend the factorial to non-integer inputs, negative inputs, or even complex inputs by defining it in terms of the gamma function. However, even then, it is undefined for negative integer inputs. Regards, Dean [1] https://en.wikipedia.org/wiki/Factorial [2] https://en.wikipedia.org/wiki/Gamma_function
Commits
-
Disallow factorial of negative numbers
- 0a40563eadc6 14.0 landed
-
Expand tests for factorial
- 9d402c73ade4 14.0 landed
-
doc: Document factorial function
- 4c5cf5431410 14.0 landed
-
Attached is a patch implementing factorial(), returning numeric. Points
- 04a4821adef3 8.0.0 cited