Horton

Re: [PATCH] Fix old thinko in formula to compute sweight in numeric_sqrt().

Dean Rasheed <dean.a.rasheed@gmail.com>

View thread View on postgr.es
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: Joel Jacobson <joel@compiler.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-02-02T09:49:33Z
Lists: pgsql-hackers 
On Tue, 31 Jan 2023 at 21:59, Joel Jacobson <joel@compiler.org> wrote:
>
> Nice, you managed to simplify it even further.
> I think the comment and the code now are crystal clear together.
>
> I've tested it successfully, test report attached.
>

Cool. Thanks for testing.
Committed.

Regards,
Dean

Commits

  1. Clarify the choice of rscale in numeric_sqrt().

  2. Ensure that numeric.c compiles with other NBASE values.