Horton

Thread

Commits

  1. Update MERGE docs to mention that ONLY is supported.

  1. Documenting MERGE INTO ONLY ...

    Dean Rasheed <dean.a.rasheed@gmail.com> — 2022-12-08T15:26:52Z

    While testing MERGE, I noticed that it supports inheritance
hierarchies and the ONLY keyword, but that isn't documented. Attached
is a patch to merge.sgml, borrowing text from update.sgml and
delete.sgml.

I note that there are also a couple of places early in the manual
(advanced.sgml and ddl.sgml) that also discuss inheritance, citing
SELECT, UPDATE and DELETE as examples of (already-discussed) commands
that support ONLY. However, since MERGE isn't mentioned until much
later in the manual, it's probably best to leave those as-is. They
don't claim to be complete lists of commands supporting ONLY, and it
would be a pain to make them that.

Regards,
Dean

  2. Re: Documenting MERGE INTO ONLY ...

    Nathan Bossart <nathandbossart@gmail.com> — 2022-12-08T19:08:08Z

    On Thu, Dec 08, 2022 at 03:26:52PM +0000, Dean Rasheed wrote:
> While testing MERGE, I noticed that it supports inheritance
> hierarchies and the ONLY keyword, but that isn't documented. Attached
> is a patch to merge.sgml, borrowing text from update.sgml and
> delete.sgml.

LGTM.  I didn't see any tests for this in merge.sql or inherit.sql.  Do you
think we should add some?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  3. Re: Documenting MERGE INTO ONLY ...

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2022-12-09T10:02:27Z

    On 2022-Dec-08, Nathan Bossart wrote:

> On Thu, Dec 08, 2022 at 03:26:52PM +0000, Dean Rasheed wrote:
> > While testing MERGE, I noticed that it supports inheritance
> > hierarchies and the ONLY keyword, but that isn't documented. Attached
> > is a patch to merge.sgml, borrowing text from update.sgml and
> > delete.sgml.
> 
> LGTM.

LGTM2.

> I didn't see any tests for this in merge.sql or inherit.sql.  Do you
> think we should add some?

Ouch!  We should definitely have some.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

  4. Re: Documenting MERGE INTO ONLY ...

    Dean Rasheed <dean.a.rasheed@gmail.com> — 2022-12-09T10:09:38Z

    On Fri, 9 Dec 2022 at 10:02, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2022-Dec-08, Nathan Bossart wrote:
>
> > On Thu, Dec 08, 2022 at 03:26:52PM +0000, Dean Rasheed wrote:
> > > While testing MERGE, I noticed that it supports inheritance
> > > hierarchies and the ONLY keyword, but that isn't documented. Attached
> > > is a patch to merge.sgml, borrowing text from update.sgml and
> > > delete.sgml.
> >
> > LGTM.
>
> LGTM2.
>
> > I didn't see any tests for this in merge.sql or inherit.sql.  Do you
> > think we should add some?
>
> Ouch!  We should definitely have some.
>

Agreed. I just pushed this, with some additional tests.

Regards,
Dean