Re: Patch: add timing of buffer I/O requests
Peter Geoghegan <peter@2ndquadrant.com>
From: Peter Geoghegan <peter@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Ants Aasma <ants@cybertec.at>, Greg Smith <greg@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2012-04-14T13:54:39Z
Lists: pgsql-hackers
On 10 April 2012 19:10, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Hmm. Maybe we should think about numeric ms, which would have all the >> same advantages but without the round-off error. > > Color me unimpressed ... numeric calculations are vastly more expensive > than float, and where are you going to get timing data that has more > than sixteen decimal digits of accuracy? +1 Besides, how do you propose to solve the problem of storing numerics in a fixed allocation of shared memory? The only comparable thing in pg_stat_statements is the query string, which is capped at track_activity_query_size bytes for this very reason. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services