Re: [PATCH 04/16] Add embedded list interface (header only)

Peter Geoghegan <peter@2ndquadrant.com>

From: Peter Geoghegan <peter@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Andres Freund <andres@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org

Date: 2012-06-22T00:32:02Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Don't waste the last segment of each 4GB logical log file.
- dfda6ebaec67 9.3.0 cited
Stamp HEAD as 9.3devel.
- bed88fceac04 9.3.0 cited
Wake WALSender to reduce data loss at failover for async commit.
- 2c8a4e9be273 9.2.0 cited
Make the visibility map crash-safe.
- 503c7305a1e3 9.2.0 cited

On 22 June 2012 01:04, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> This is nonsense.  There are at least three buildfarm machines running
> compilers that do not "pretend to be gcc" (at least, configure
> recognizes them as not gcc) and are not MSVC either.

So those three don't have medium to high degrees of compatibility with GCC?

> We ought to have more IMO, because software monocultures are dangerous.  Of
> those three, two pass the "quiet inline" test and one --- the newest of the three
> if I guess correctly --- does not.  So it is not the case that
> !USE_INLINE is dead code, even if you adopt the position that we don't
> care about any compiler not represented in the buildfarm.

I note that you said that it doesn't pass the "quiet inline" test, and
not that it doesn't support inline functions.

-- 
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services