Re: Allow pg_dumpall to work without pg_authid
Robins Tharakan <tharakan@gmail.com>
From: Robins Tharakan <tharakan@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-02-19T14:42:49Z
Lists: pgsql-hackers
Attachments
- pgdumpall_nopgauthid_flag.diff.gz (application/x-gzip) patch
On 19 February 2017 at 17:02, Robins Tharakan <tharakan@gmail.com> wrote: > > On Sun, 19 Feb 2017 at 10:08 Stephen Frost <sfrost@snowman.net> wrote: > >> If anything, it should use pg_roles, not pg_user. >> >> I don't really like the "--avoid-pgauthid" option, but "--no-passwords" >> would probably work. >> >> > '--no-passwords' is a good alternative. > Would submit a patch soon. > > After reviewing further, it seems that merely adding a password related workaround wouldn't suffice. Further --no-password is already an alias for -w, so that flag is effectively taken. Since the main restriction with AWS RDS is the unavailability of pg_authid, probably that is a better basis to name the flag on. Attaching a patch to add a new flag (--no-pgauthid) to pg_dumpall that can dump Globals without needing pg_authid. So the following works with AWS RDS Postgres databases. pg_dumpall --no-pgauthid --globals-only > a.sql I'll create a Commitfest entry, if there aren't many objections. - robins
Commits
-
Fix dumping role comments when using --no-role-passwords
- d82cb467bbc2 12.19 landed
- be01c8c3450e 14.12 landed
- affc46b76d50 13.15 landed
- 7e65ad197f9d 17.0 landed
- 5863bacb87c1 16.3 landed
- 12128be623fd 15.7 landed