Re: Patch: Add --no-comments to skip COMMENTs with pg_dump

Robins Tharakan <tharakan@gmail.com>

From: Robins Tharakan <tharakan@gmail.com>

To: David Fetter <david@fetter.org>

Cc: Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Stephen Frost <sfrost@snowman.net>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2017-07-19T18:54:15Z

Lists: pgsql-hackers

Attachments

pgdump_nocomments_v2.patch (application/octet-stream) patch v2

On 18 July 2017 at 23:55, David Fetter <david@fetter.org> wrote:
>
> Excellent point about pg_dumpall.  I'll see what I can draft up in the
> next day or two and report back.

Hi David,

You may want to consider this patch (attached) which additionally has the
pg_dumpall changes.
It would be great if you could help with the tests though, am unsure how to
go about them.

-
robins

Commits

Support --no-comments in pg_dump, pg_dumpall, pg_restore.
- 1368e92e16a0 11.0 landed
Improve pg_dump's handling of "special" built-in objects.
- 5955d934194c 11.0 landed