Horton
Menu

Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

Robins Tharakan <tharakan@gmail.com>

View thread
From: Robins Tharakan <tharakan@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-bugs@lists.postgresql.org
Date: 2025-03-06T07:20:59Z
Lists: pgsql-bugs 
On Thu, 6 Mar 2025 at 17:13, Masahiko Sawada <sawada.mshk@gmail.com> wrote:

> On Tue, Mar 4, 2025 at 10:44 PM Bertrand Drouvot
> <bertranddrouvot.pg@gmail.com> wrote:
> >
> > After sleeping on it, PFA a simplified version.
>

Running tests on v5 patch for a few hours was uneventful (which is good).



> I think we don't need to even do palloc() for the buffer as we can use
> the char[MAXPGPATH] instead. I've attached the patch to improve the
> parse_snapshot_filename() function and add some regression tests.
> Please review these changes.
>


I've updated that with this patch too. Will update if something comes up.

-
robins

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_logicalinspect: Fix possible crash when passing a directory path.

  2. Add contrib/pg_logicalinspect.

  3. Fix compiler warning on Windows.