Patch: Add --no-comments to skip COMMENTs with pg_dump
Robins Tharakan <tharakan@gmail.com>
From: Robins Tharakan <tharakan@gmail.com>
To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-05-26T13:58:57Z
Lists: pgsql-hackers
Attachments
- pgdump_nocomments_v1.patch (application/octet-stream) patch v1
Hi, Attached is a patch adds a --no-comments argument to pg_dump to skip generation of COMMENT statements when generating a backup. This is crucial for non-superusers to restore a database backup in a Single Transaction. Currently, this requires one to remove COMMENTs via scripts, which is inelegant at best. A similar discussion had taken place earlier [1], however that stopped (with a Todo entry) since it required more work at the backend. This patch provides a stop-gap solution until then. If the feedback is to tackle this is by filtering comments for specific DB objects, an argument name (for e.g. --no-extension-comments or something) would help and I could submit a revised patch. Alternatively, if there are no objections, I could submit this to the Commitfest. References: [1] https://www.postgresql.org/message-id/1420.1397099637%40sss.pgh.pa.us - robins
Commits
-
Support --no-comments in pg_dump, pg_dumpall, pg_restore.
- 1368e92e16a0 11.0 landed
-
Improve pg_dump's handling of "special" built-in objects.
- 5955d934194c 11.0 landed