Re: [dsm] comment typo
Junwang Zhao <zhjwpku@gmail.com>
From: Junwang Zhao <zhjwpku@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Robert Haas <robertmhaas@gmail.com>
Date: 2023-08-21T10:15:36Z
Lists: pgsql-hackers
On Mon, Aug 21, 2023 at 5:16 PM Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 18 Aug 2023, at 11:10, Junwang Zhao <zhjwpku@gmail.com> wrote: > > > > In the following sentence, I believe either 'the' or 'a' should be kept, not > > both. I here keep the 'the', but feel free to change. > > > * handle: The handle of an existing object, or for DSM_OP_CREATE, the > > - * a new handle the caller wants created. > > + * new handle the caller wants created. > > Since the handle doesn't exist for DSM_OP_CREATE, both "a handle" and "the > handle" seems a tad misleading, how about "the identifier for the new handle the > caller wants created"? > Sounds great 👍 > -- > Daniel Gustafsson > -- Regards Junwang Zhao
Commits
-
Fix wording in comment
- 27a36f79b6d1 17.0 landed