Re: SQL Property Graph Queries (SQL/PGQ)

Junwang Zhao <zhjwpku@gmail.com>

From: Junwang Zhao <zhjwpku@gmail.com>

To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

Cc: Peter Eisentraut <peter@eisentraut.org>, Amit Langote <amitlangote09@gmail.com>, Vik Fearing <vik@postgresfriends.org>, Ajay Pal <ajay.pal.k@gmail.com>, Imran Zaheer <imran.zhir@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-11-24T06:03:47Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix some typos and make small stylistic improvements
- 5282bf535e47 19 (unreleased) landed
Cleanup users and roles in graph_table_rls test
- 040a56be4bcc 19 (unreleased) landed
Dump labels in reproducible order
- c9babbc8816a 19 (unreleased) landed
SQL Property Graph Queries (SQL/PGQ)
- 2f094e7ac691 19 (unreleased) landed
Factor out constructSetOpTargetlist() from transformSetOperationTree()
- 8c2b30487cc7 19 (unreleased) landed
Sort out table_open vs. relation_open in rewriter
- d537f59fbbfc 19 (unreleased) landed
Rename grammar nonterminal to simplify reuse
- 8080f44f96a9 19 (unreleased) landed
Make ecpg parse.pl more robust with braces
- 7f88553ceaca 19 (unreleased) landed
Don't lock partitions pruned by initial pruning
- 525392d5727f 18.0 cited
Remove pg_regex_collation
- 792b2c7e6d92 18.0 cited
Use auxv to check for CRC32 instructions on ARM.
- aac831cafa6f 18.0 cited
Fix inappropriate uses of atol()
- f5a1311fccd2 18.0 cited
Remove unnecessary array object_classes[] in dependency.c
- ef5e2e90859a 17.0 cited

On Mon, Nov 24, 2025 at 1:00 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> Hi Junwang,
>
> On Mon, Nov 24, 2025 at 8:01 AM Junwang Zhao <zhjwpku@gmail.com> wrote:
> >
> > Hi Ashutosh,
> >
> > On Thu, Nov 20, 2025 at 11:01 PM Ashutosh Bapat
> > <ashutosh.bapat.oss@gmail.com> wrote:
> > >
> > > Hi Junwang,
> > >
> > > On Sun, Aug 31, 2025 at 4:35 PM Junwang Zhao <zhjwpku@gmail.com> wrote:
> > > >
> > > >
> > > > I have some review comments, and hope some of them are helpful.
> > > >
> > > > 1.
> > > >
> > > > doc/src/sgml/ddl.sgml
> > > >
> > > > +<programlisting>
> > > > +CREATE PROPERTY GRAPH myshop
> > > > +    VERTEX TABLES (
> > > > +        products LABEL product,
> > > > +        customers LABEL customer,
> > > > +        orders LABEL order
> > > > +    )
> > > > +    EDGE TABLES (
> > > > +        order_items SOURCE orders DESTINATION products LABEL contains,
> > > > +        customer_orders SOURCE customers DESTINATION orders LABEL has
> > > > +    );
> > > > +</programlisting>
> > > >
> > > > order is a reserved keyword, so the following example will fail, we
> > > > should not give a wrong example in our document.
> > > >
> > >
> > > I tried those examples and they all worked. What error are you
> > > getting? What is not working for you?
> >
> > Here is what I got, pay attention to the queries with singular `order`, it's a
> > reserved keyword.
>
> I see it now. Sorry for missing it earlier.
>
> I think something like attached should fix the problem, if we want to
> continue with the current example. FWIW, it demos that quotes can be
> used with labels, but we don't necessarily do that with other objects.
> I am not sure whether Peter would like to continue with the example or
> use a different one avoiding this subtlety altogether. Hence not
> including it in the overall patchset.
>

The patch WFM. Using a different one also works, maybe we can adopt
part of the schema from LDBC SNB [1]

[1] https://ldbcouncil.org/benchmarks/snb/


>
> --
> Best Wishes,
> Ashutosh Bapat



-- 
Regards
Junwang Zhao