Thread

Commits

Remove an extra period in code comment
- d7db04dfdae3 18.0 landed

report a typo in comments of ComputeXidHorizonsResult

Junwang Zhao <zhjwpku@gmail.com> — 2024-07-07T09:42:47Z

I think the period here should be a typo.

index 16b5803d388..af3b15e93df 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -185,7 +185,7 @@ typedef struct ComputeXidHorizonsResult
        FullTransactionId latest_completed;

        /*
-        * The same for procArray->replication_slot_xmin and.
+        * The same for procArray->replication_slot_xmin and
         * procArray->replication_slot_catalog_xmin.
         */

-- 
Regards
Junwang Zhao

Re: report a typo in comments of ComputeXidHorizonsResult

Richard Guo <guofenglinux@gmail.com> — 2024-07-07T23:49:43Z

On Sun, Jul 7, 2024 at 5:43 PM Junwang Zhao <zhjwpku@gmail.com> wrote:
> I think the period here should be a typo.
>
> index 16b5803d388..af3b15e93df 100644
> --- a/src/backend/storage/ipc/procarray.c
> +++ b/src/backend/storage/ipc/procarray.c
> @@ -185,7 +185,7 @@ typedef struct ComputeXidHorizonsResult
>         FullTransactionId latest_completed;
>
>         /*
> -        * The same for procArray->replication_slot_xmin and.
> +        * The same for procArray->replication_slot_xmin and
>          * procArray->replication_slot_catalog_xmin.
>          */

+1.

Thanks
Richard

Re: report a typo in comments of ComputeXidHorizonsResult

Richard Guo <guofenglinux@gmail.com> — 2024-07-08T02:36:44Z

On Mon, Jul 8, 2024 at 7:49 AM Richard Guo <guofenglinux@gmail.com> wrote:
> On Sun, Jul 7, 2024 at 5:43 PM Junwang Zhao <zhjwpku@gmail.com> wrote:
> > I think the period here should be a typo.
> >
> > index 16b5803d388..af3b15e93df 100644
> > --- a/src/backend/storage/ipc/procarray.c
> > +++ b/src/backend/storage/ipc/procarray.c
> > @@ -185,7 +185,7 @@ typedef struct ComputeXidHorizonsResult
> >         FullTransactionId latest_completed;
> >
> >         /*
> > -        * The same for procArray->replication_slot_xmin and.
> > +        * The same for procArray->replication_slot_xmin and
> >          * procArray->replication_slot_catalog_xmin.
> >          */
>
> +1.

Pushed.

Thanks
Richard