Thread

Commits

  1. Typo fix

  1. a potential typo in comments of pg_parse_json

    Junwang Zhao <zhjwpku@gmail.com> — 2024-07-08T08:24:49Z

    Not 100% sure, sorry if this doesn't make sense.
    
    --- a/src/common/jsonapi.c
    +++ b/src/common/jsonapi.c
    @@ -514,7 +514,7 @@ freeJsonLexContext(JsonLexContext *lex)
      *
      * If FORCE_JSON_PSTACK is defined then the routine will call the non-recursive
      * JSON parser. This is a useful way to validate that it's doing the right
    - * think at least for non-incremental cases. If this is on we expect to see
    + * thing at least for non-incremental cases. If this is on we expect to see
      * regression diffs relating to error messages about stack depth, but no
      * other differences.
      */
    
    
    -- 
    Regards
    Junwang Zhao
    
    
    
    
  2. Re: a potential typo in comments of pg_parse_json

    Amit Langote <amitlangote09@gmail.com> — 2024-07-08T13:16:33Z

    On Mon, Jul 8, 2024 at 5:25 PM Junwang Zhao <zhjwpku@gmail.com> wrote:
    > Not 100% sure, sorry if this doesn't make sense.
    >
    > --- a/src/common/jsonapi.c
    > +++ b/src/common/jsonapi.c
    > @@ -514,7 +514,7 @@ freeJsonLexContext(JsonLexContext *lex)
    >   *
    >   * If FORCE_JSON_PSTACK is defined then the routine will call the non-recursive
    >   * JSON parser. This is a useful way to validate that it's doing the right
    > - * think at least for non-incremental cases. If this is on we expect to see
    > + * thing at least for non-incremental cases. If this is on we expect to see
    >   * regression diffs relating to error messages about stack depth, but no
    >   * other differences.
    >   */
    
    Good catch.  Fixed.
    
    
    --
    Thanks, Amit Langote