Re: BUG #17903: There is a bug in the KeepLogSeg()

Junwang Zhao <zhjwpku@gmail.com>

From: Junwang Zhao <zhjwpku@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: xu.xw2008@163.com, pgsql-bugs@lists.postgresql.org
Date: 2023-04-20T11:17:02Z
Lists: pgsql-bugs
This patch looks reasonable.

+1

On Thu, Apr 20, 2023 at 4:58 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> At Thu, 20 Apr 2023 15:40:14 +0800, Junwang Zhao <zhjwpku@gmail.com> wrote in
> > If `segno` can be larger than `currSegNo`, your patch seems to miss
> > the following branch,
> > are you missing this for some particular reason?
>
> Oops! Sorry for the mistake and thanks for pointing it out.
>
> I should have kept segno within the reasonable range.
>
> regards.
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center



-- 
Regards
Junwang Zhao



Commits

  1. Prevent underflow in KeepLogSeg().