Horton

Thread

Commits

  1. Remove redundant wording in pg_statistic.h

  1. Should fix a comment referring to stats collector?

    torikoshia <torikoshia@oss.nttdata.com> — 2022-07-29T13:05:56Z

    Hi,

Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there 
was a comment referring 'statistics collector' in pg_statistic.h.

>  Note that since the arrays are variable-size, K may be chosen by the 
> statistics collector.

Should it be modified to 'cumulative statistics system' like manual on 
monitoring stats[1]?
Its title has changed from 'statistics collector' to 'cumulative 
statistics system'.

[1] https://www.postgresql.org/docs/current/monitoring-stats.html

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

  2. Re: Should fix a comment referring to stats collector?

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2022-07-29T17:53:51Z

    On 2022-Jul-29, torikoshia wrote:

> Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there was
> a comment referring 'statistics collector' in pg_statistic.h.
> 
> >  Note that since the arrays are variable-size, K may be chosen by the
> > statistics collector.
> 
> Should it be modified to 'cumulative statistics system' like manual on
> monitoring stats[1]?

I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.
Maybe it should just say "K may be chosen at ANALYZE time".

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Nadie está tan esclavizado como el que se cree libre no siéndolo" (Goethe)

  3. Re: Should fix a comment referring to stats collector?

    torikoshia <torikoshia@oss.nttdata.com> — 2022-08-01T12:05:45Z

    On 2022-07-30 02:53, Alvaro Herrera wrote:

> I don't think this refers to the statistics collector process; I
> understand it to refer to ANALYZE that captures the data being stored.

Thanks for the explanation!

> Maybe it should just say "K may be chosen at ANALYZE time".

It seems clearer than current one.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

  4. Re: Should fix a comment referring to stats collector?

    Bruce Momjian <bruce@momjian.us> — 2023-10-31T15:02:19Z

    On Mon, Aug  1, 2022 at 09:05:45PM +0900, torikoshia wrote:
> On 2022-07-30 02:53, Alvaro Herrera wrote:
> 
> > I don't think this refers to the statistics collector process; I
> > understand it to refer to ANALYZE that captures the data being stored.
> 
> Thanks for the explanation!
> 
> > Maybe it should just say "K may be chosen at ANALYZE time".
> 
> It seems clearer than current one.

Change made in master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

  5. Re: Should fix a comment referring to stats collector?

    Junwang Zhao <zhjwpku@gmail.com> — 2024-12-28T07:25:46Z

    On Tue, Oct 31, 2023 at 11:02 PM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Mon, Aug  1, 2022 at 09:05:45PM +0900, torikoshia wrote:
> > On 2022-07-30 02:53, Alvaro Herrera wrote:
> >
> > > I don't think this refers to the statistics collector process; I
> > > understand it to refer to ANALYZE that captures the data being stored.
> >
> > Thanks for the explanation!
> >
> > > Maybe it should just say "K may be chosen at ANALYZE time".
> >
> > It seems clearer than current one.
>
> Change made in master.

I believe some redundant wording has been committed.

K may be chosen may be chosen at ANALYZE time.

Attached patch fixes it and with some line adjustments.

>
> --
>   Bruce Momjian  <bruce@momjian.us>        https://momjian.us
>   EDB                                      https://enterprisedb.com
>
>   Only you can decide what is important to you.
>
>


-- 
Regards
Junwang Zhao

  6. Re: Should fix a comment referring to stats collector?

    Michael Paquier <michael@paquier.xyz> — 2024-12-30T03:20:26Z

    On Sat, Dec 28, 2024 at 03:25:46PM +0800, Junwang Zhao wrote:
> I believe some redundant wording has been committed.
> 
> K may be chosen may be chosen at ANALYZE time.
> 
> Attached patch fixes it and with some line adjustments.

Indeed.  Fixed, thanks!
--
Michael