Horton

Re: Use RELATION_IS_OTHER_TEMP where possible

Junwang Zhao <zhjwpku@gmail.com>

View thread
From: Junwang Zhao <zhjwpku@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-06-11T11:35:39Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make more use of RELATION_IS_OTHER_TEMP().

Hi Ashutosh,

On Wed, Jun 11, 2025 at 7:11 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
>
>
> On Wed, Jun 11, 2025 at 5:12 AM Junwang Zhao <zhjwpku@gmail.com> wrote:
>>
>> Hi Nathan,
>>
>> On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart
>> <nathandbossart@gmail.com> wrote:
>> >
>> > On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote:
>> > > All other files perform this check using RELATION_IS_OTHER_TEMP.
>> > > Should we update tablecmds.c to do the same for consistency?
>> >
>> > Seems like a good idea.
>>
>> Thanks for the comment.
>>
>> I have attached a patch with the proposed changes.
>
>
> LGTM. I looked at other instances of is_localtemp, but none of them have (relation)->rd_rel->relpersistence == RELPERSISTENCE_TEMP there. Your patch has covered all the existing ones.

Thank you for the review and the additional check.

I have created a cf entry to track this.

https://commitfest.postgresql.org/patch/5815/

>
> --
> Best Wishes,
> Ashutosh Bapat



-- 
Regards
Junwang Zhao