Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

Paul Guo <pguo@pivotal.io>

From: Paul Guo <pguo@pivotal.io>

To: Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Michael Paquier <michael@paquier.xyz>, Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Jimmy Yih <jyih@pivotal.io>, Ashwin Agrawal <aagrawal@pivotal.io>

Date: 2019-09-05T07:41:14Z

Lists: pgsql-hackers

Attachments

v5-0001-Extact-common-functions-from-pg_basebackup-into-s.patch (application/octet-stream) patch v5-0001
v5-0002-Add-option-to-write-recovery-configuration-inform.patch (application/octet-stream) patch v5-0002
v5-0003-Ensure-target-clean-shutdown-at-the-beginning-of-.patch (application/octet-stream) patch v5-0003

>
> It seems there's minor breakage in the build,  per CFbot.  Can you
> please rebase this?
>
> There is a code conflict. See attached for the new version. Thanks.

Commits

Improve test coverage of pg_rewind
- 55ba56415bae 13.0 landed
Improve handling and coverage of --no-ensure-shutdown in pg_rewind
- caa078353ecd 13.0 landed
Fix issues in pg_rewind with --no-ensure-shutdown/--write-recovery-conf
- 6837632b758e 13.0 landed
Fix --dry-run mode of pg_rewind
- c2e3b311d9ef 12.1 landed
- 6f3823b03560 13.0 landed
pg_rewind: test new --write-recovery-conf functionality
- 7524c788743f 13.0 landed
pg_rewind: Allow writing recovery configuration
- 927474ce1a24 13.0 landed
Have pg_rewind run crash recovery before rewinding
- 5adafaf176d0 13.0 landed
Split out recovery confing-writing code from pg_basebackup
- caba97a9d9f4 13.0 landed
Switch TAP tests of pg_rewind to use non-superuser role, take two
- d9f543e9e9be 12.0 cited