Horton

Thread

Commits

  1. Doc: Fix minor formatting issue in logicaldecoding.sgml.

  1. Weird use of parentheses in the manual

    Guillaume Lelarge <guillaume@lelarge.info> — 2021-06-24T11:57:09Z

    Hey,

I was translating logicaldecoding.sgml, and I saw this sentence:

There are multiple required streaming callbacks
(<function>stream_start_cb</function>, <function>stream_stop_cb</function>,
<function>stream_abort_cb</function>, <function>stream_commit_cb</function>
and <function>stream_change_cb</function>) and two optional callbacks
(<function>stream_message_cb</function>) and
(<function>stream_truncate_cb</function>).

The two last sets of parentheses seem really weird to me. Looks like it
should be:
(<function>stream_message_cb</function> and
<function>stream_truncate_cb</function>).

Really tiny patch attached to fix this if it really is wrong, and anyone
cares enough to fix it :)

Regards.


-- 
Guillaume.

  2. Re: Weird use of parentheses in the manual

    Amit Kapila <amit.kapila16@gmail.com> — 2021-06-24T13:08:22Z

    On Thu, Jun 24, 2021 at 5:27 PM Guillaume Lelarge
<guillaume@lelarge.info> wrote:
>
> Really tiny patch attached to fix this if it really is wrong, and anyone cares enough to fix it :)
>

LGTM. I'll take care of this tomorrow unless someone else has any
suggestions in this regard.

-- 
With Regards,
Amit Kapila.

  3. Re: Weird use of parentheses in the manual

    Amit Kapila <amit.kapila16@gmail.com> — 2021-06-25T06:55:15Z

    On Thu, Jun 24, 2021 at 6:38 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, Jun 24, 2021 at 5:27 PM Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
> >
> > Really tiny patch attached to fix this if it really is wrong, and anyone cares enough to fix it :)
> >
>
> LGTM. I'll take care of this tomorrow unless someone else has any
> suggestions in this regard.
>

Pushed.

-- 
With Regards,
Amit Kapila.

  4. Re: Weird use of parentheses in the manual

    Guillaume Lelarge <guillaume@lelarge.info> — 2021-06-25T07:02:48Z

    Le ven. 25 juin 2021 à 08:55, Amit Kapila <amit.kapila16@gmail.com> a
écrit :

> On Thu, Jun 24, 2021 at 6:38 PM Amit Kapila <amit.kapila16@gmail.com>
> wrote:
> >
> > On Thu, Jun 24, 2021 at 5:27 PM Guillaume Lelarge
> > <guillaume@lelarge.info> wrote:
> > >
> > > Really tiny patch attached to fix this if it really is wrong, and
> anyone cares enough to fix it :)
> > >
> >
> > LGTM. I'll take care of this tomorrow unless someone else has any
> > suggestions in this regard.
> >
>
> Pushed.
>
>
Thanks.


-- 
Guillaume.