Re: Exclude pg_largeobject form pg_dump

2016-11-08 6:01 GMT+01:00 amul sul <sulamul@gmail.com>:

> On Tue, Nov 8, 2016 at 5:36 AM, Andreas Joseph Krogh <andreas@visena.com>
> wrote:
> >
> >
> > I don't see what you mean. It forces dump of Blobs if we didn't use -B
> and
> > if we include everything in the dump, which seems good to me. What did
> you
> > try that didn't work as expected?
> >
> >
> > I guess what he means is that if -B is given, the following code sets
> > dopt.outputBlobs = false
> >
> > +            case 'B':            /* Don't dump blobs */
> > +                dopt.outputBlobs = false;
> > +                break;
> >
> >
> > Then this IF sets it back to TRUE:
> >
> > +    if (dopt.include_everything && !dopt.schemaOnly &&
> !dopt.outputBlobs)
> >          dopt.outputBlobs = true;
> >
> >
> > ...making it impossible to turn off dumping of blobs.
> >
>
> Yes, thats the reason v4 patch  was not as expected.
>
>
It took me some time but I finally understand.

Behaviour fix in v6.


-- 
Guillaume.
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com