Horton

Thread

Commits

  1. doc: Fix inconsistencies in GIN, BRIN and SP-GiST for optional opclass methods

  1. Quick doc patch

    Guillaume Lelarge <guillaume@lelarge.info> — 2020-07-07T07:17:15Z

    Hi,

Here is a quick issue I found on the BRIN documentation. I'm not a 100%
sure I'm right but it looks like a failed copy/paste from the GIN
documentation.

Cheers.


-- 
Guillaume.

  2. Re: Quick doc patch

    Daniel Gustafsson <daniel@yesql.se> — 2020-07-07T07:58:59Z

    > On 7 Jul 2020, at 09:17, Guillaume Lelarge <guillaume@lelarge.info> wrote:

> Here is a quick issue I found on the BRIN documentation. I'm not a 100% sure I'm right but it looks like a failed copy/paste from the GIN documentation.

I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
paragraph for both GIN and BRIN.  LGTM.  Adding Alexander who committed in on
cc.

cheers ./daniel

  3. Re: Quick doc patch

    Michael Paquier <michael@paquier.xyz> — 2020-07-07T09:36:10Z

    On Tue, Jul 07, 2020 at 09:58:59AM +0200, Daniel Gustafsson wrote:
> I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
> paragraph for both GIN and BRIN.  LGTM.  Adding Alexander who committed in on
> cc.

+1.
--
Michael

  4. Re: Quick doc patch

    Michael Paquier <michael@paquier.xyz> — 2020-07-08T01:43:02Z

    On Tue, Jul 07, 2020 at 06:36:10PM +0900, Michael Paquier wrote:
> On Tue, Jul 07, 2020 at 09:58:59AM +0200, Daniel Gustafsson wrote:
>> I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
>> paragraph for both GIN and BRIN.  LGTM.  Adding Alexander who committed in on
>> cc.
> 
> +1.

Alexander does not seem to be around, so I have just applied the fix.
There were more inconsistencies in gin.sgml and spgist.sgml missed in
14903f2, making the docs of GIN/SP-GiST less in line with the BRIN
equivalent, so I have fixed both while on it.
--
Michael

  5. Re: Quick doc patch

    Alexander Korotkov <aekorotkov@gmail.com> — 2020-07-08T11:00:31Z

    Hi!

On Wed, Jul 8, 2020 at 4:43 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Jul 07, 2020 at 06:36:10PM +0900, Michael Paquier wrote:
> > On Tue, Jul 07, 2020 at 09:58:59AM +0200, Daniel Gustafsson wrote:
> >> I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
> >> paragraph for both GIN and BRIN.  LGTM.  Adding Alexander who committed in on
> >> cc.
> >
> > +1.
>
> Alexander does not seem to be around, so I have just applied the fix.
> There were more inconsistencies in gin.sgml and spgist.sgml missed in
> 14903f2, making the docs of GIN/SP-GiST less in line with the BRIN
> equivalent, so I have fixed both while on it.

I just read this thread.
Thank you for fixing this!

------
Regards,
Alexander Korotkov