Re: Extensions not dumped when --schema is used
Guillaume Lelarge <guillaume@lelarge.info>
From: Guillaume Lelarge <guillaume@lelarge.info>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-18T10:13:06Z
Lists: pgsql-hackers
Attachments
- dump_extensions_v2.patch (text/x-patch) patch v2
Le mar. 26 janv. 2021 à 13:42, Guillaume Lelarge <guillaume@lelarge.info> a écrit : > Le mar. 26 janv. 2021 à 13:41, Guillaume Lelarge <guillaume@lelarge.info> > a écrit : > >> Le mar. 26 janv. 2021 à 05:10, Julien Rouhaud <rjuju123@gmail.com> a >> écrit : >> >>> On Mon, Jan 25, 2021 at 9:34 PM Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>> > >>> > "Anytime soon" was a long long time ago, and I eventually completely >>> forgot this, sorry. As nobody worked on it yet, I took a shot at it. See >>> attached patch. >>> >>> Great! >>> >>> I didn't reviewed it thoroughly yet, but after a quick look it sounds >>> sensible. I'd prefer to see some tests added, and it looks like a >>> test for plpgsql could be added quite easily. >>> >>> >> I tried that all afternoon yesterday, but failed to do so. My had still >> hurts, but I'll try again though it may take some time. >> >> > s/My had/My head/ .. > > I finally managed to get a working TAP test for my patch. I have no idea if it's good, and if it's enough. Anyway, new version of the patch attached. -- Guillaume.
Commits
-
Tweak behavior of pg_dump --extension with configuration tables
- 344487e2db03 14.0 landed
-
Remove duplicated --no-sync switches in new tests of test_pg_dump
- 885a87641930 14.0 landed
-
Add support for --extension in pg_dump
- 6568cef26e0f 14.0 landed