Horton

Re: Improve pg_sync_replication_slots() to wait for primary to advance

Ashutosh Sharma <ashu.coek88@gmail.com>

View thread
From: Ashutosh Sharma <ashu.coek88@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Ajin Cherian <itsajin@gmail.com>, shveta malik <shveta.malik@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2025-09-08T04:26:49Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Enhance slot synchronization API to respect promotion signal.

  2. Fix inconsistent elevel in pg_sync_replication_slots() retry logic.

  3. Refactor slot synchronization logic in slotsync.c.

  4. Fix intermittent BF failure in 040_standby_failover_slots_sync.

  5. Add retry logic to pg_sync_replication_slots().

  6. Fix LOCK_TIMEOUT handling in slotsync worker.

  7. Add slotsync skip statistics.

On Mon, Sep 8, 2025 at 9:51 AM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Sat, Sep 6, 2025 at 9:14 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Fri, Sep 5, 2025 at 11:39 PM Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> > > If the remote slot is inactive since long and lagging behind the
> > > standby, this function (pg_sync_replication_slots) could end up
> > > waiting indefinitely. While it can certainly be cancelled manually,
> > > that behavior might not be ideal for everyone. That’s my
> > > understanding; please let me know if you see it differently.
> > >
> >
> > Such a case can be addressed by having additional timeout parameters.
> > We can do that as an additional patch if the use case is important
> > enough to address.
> >
>
> Or we could rely on statement_timeout or the user cancelling the query
> explicitly.
>

Sure. thanks Amit and Ashutosh.

--
With Regards,
Ashutosh Sharma.