Horton

Re: issue with synchronized_standby_slots

Ashutosh Sharma <ashu.coek88@gmail.com>

View thread
From: Ashutosh Sharma <ashu.coek88@gmail.com>
To: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Alexander Kukushkin <cyberdemn@gmail.com>, Fabrice Chapuis <fabrice636861@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-24T06:44:13Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix GUC check_hook validation for synchronized_standby_slots.

  2. Make invalid primary_slot_name follow standard GUC error reporting.

Hi Amit,

On Tue, Sep 23, 2025 at 1:00 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
>
> On Tue, 23 Sept 2025 at 09:55, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Fri, Sep 12, 2025 at 2:34 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
> > >
> > > I have attached the updated v4 patch
> > >
> >
> > +# Cannot be set synchronized_standby_slots to a reserved slot name
> > +($result, $stdout, $stderr) = $primary->psql('postgres',
> > + "ALTER SYSTEM SET synchronized_standby_slots='pg_conflict_detection'");
> > +ok( $stderr =~
> > +   m/WARNING:  replication slot name "pg_conflict_detection" is reserved/,
> > + "Cannot use a reserverd slot name");
> > +
> > +# Cannot be set synchronized_standby_slots to slot name with invalid characters
> > +($result, $stdout, $stderr) = $primary->psql('postgres',
> > + "ALTER SYSTEM SET synchronized_standby_slots='invalid*'");
> > +ok( $stderr =~
> > +   m/WARNING:  replication slot name "invalid\*" contains invalid character/,
> > + "Cannot use a invalid slot name");
> >
> > These tests can be present in some sql file. I think you have kept
> > these in the .pl file to keep it along with other tests but I think
> > these are better suited for some .sql file.
> >
> Thanks for reviewing the patch.
> I have moved the tests to the guc.sql file. I have attached the updated patch.
>

Are we planning to wait for [1] to go in first, since this also
depends on ReplicationSlotValidateName?

[1] - https://www.postgresql.org/message-id/flat/CAHGQGwFud-cvthCTfusBfKHBS6Jj6kdAPTdLWKvP2qjUX6L_wA%40mail.gmail.com

--
With Regards,
Ashutosh Sharma.