Re: Page Scan Mode in Hash Index

Ashutosh Sharma <ashu.coek88@gmail.com>

From: Ashutosh Sharma <ashu.coek88@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Jesper Pedersen <jesper.pedersen@redhat.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2017-09-21T07:08:57Z

Lists: pgsql-hackers

Attachments

0001-Rewrite-hash-index-scan-to-work-page-at-a-time_v16.patch (text/x-patch) patch v16-0001
0002-Remove-redundant-hash-function-_hash_step-and-do-som.patch (text/x-patch) patch 0002
0003-Improve-locking-startegy-during-VACUUM-in-Hash-Index_v8.patch (text/x-patch) patch v8-0003

On Thu, Sep 21, 2017 at 9:30 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Sep 20, 2017 at 11:43 AM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>> Attached are the patches with above changes. Thanks.
>
> Thanks.  I think that the comments and README changes in 0003 need
> significantly more work.  In several places, they fail to note the
> unlogged vs. logged differences, and the header comment for
> hashbucketcleanup still says that scans depend on increasing-TID order
> (really, 0001 should change that text somehow).
>

I have added a note for handling of logged and unlogged tables in
README file and also corrected the header comment for
hashbucketcleanup(). Please find the attached 0003*.patch having these
changes. Thanks.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

Commits

Remove lsn from HashScanPosData.
- 22c5e73562c5 11.0 landed
Fix trivial mistake in README.
- 79a4a665c046 11.0 landed
hash: Implement page-at-a-time scan.
- 7c75ef571579 11.0 landed
Reduce pinning and buffer content locking for btree scans.
- 2ed5b87f96d4 9.5.0 cited