Re: pageinspect: Hash index support

Ashutosh Sharma <ashu.coek88@gmail.com>

View thread View on postgr.es

From: Ashutosh Sharma <ashu.coek88@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2017-02-09T18:11:15Z

Lists: pgsql-hackers

Attachments

simplify_hash_bitmap_info_v3.patch (application/x-download) patch v3

> I think you should just tighten up the sanity checking in the existing
> function _hash_ovflblkno_to_bitno rather than duplicating the code.  I
> don't think it's called often enough for one extra (cheap) test to be
> an issue.  (You should change the elog in that function to an ereport,
> too, since it's going to be a user-facing error message now.)

okay, I have taken care of above two points in the attached patch. Thanks.

Commits

Fix incorrect typecast.
- b4316928d57b 10.0 landed
In pageinspect/hashfuncs.c, avoid crashes on alignment-picky machines.
- 14e9b18fed28 10.0 landed
pageinspect: Support hash indexes.
- 08bf6e529587 10.0 landed
Add uuid to the set of types supported by contrib/btree_gist.
- 11da83a0e70d 10.0 cited
Allow CREATE EXTENSION to follow extension update paths.
- 40b449ae84dc 10.0 cited