Re: Microvacuum support for Hash Index

Ashutosh Sharma <ashu.coek88@gmail.com>

View thread View on postgr.es

From: Ashutosh Sharma <ashu.coek88@gmail.com>

To: Jesper Pedersen <jesper.pedersen@redhat.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2017-01-06T05:54:57Z

Lists: pgsql-hackers

Attachments

microvacuum_hash_index_v4.patch (invalid/octet-stream) patch v4
(unnamed) (text/plain)

Hi,

> using pgbench -M prepared -c 10 -j 10 -T 600 -f test.sql test
>
> crashes after a few minutes with
>
> TRAP: FailedAssertion("!(LWLockHeldByMeInMode(((LWLock*)
> (&(bufHdr)->content_lock)), LW_EXCLUSIVE))", File: "bufmgr.c", Line: 3781)

Attached v4 patch fixes this assertion failure.

> BTW, better rename 'hashkillitems' to '_hash_kill_items' to follow the
> naming convention in hash.h

okay, I have renamed 'hashkillitems' to '_hash_kill_items'. Please
check the attached v4 patch.

With Regards,
Ashutosh Sharma
EnterpriseDB: http://www.enterprisedb.com

Commits

Fixes for single-page hash index vacuum.
- 953477ca3526 10.0 landed
Port single-page btree vacuum logic to hash indexes.
- 6977b8b7f4df 10.0 landed
Avoid core dump for empty prepared statement in an aborted transaction.
- ba61a04bc7fe 10.0 cited
Change representation of statement lists, and add statement location info.
- ab1f0c822571 10.0 cited