Re: comments in hash_alloc_buckets
Ashutosh Sharma <ashu.coek88@gmail.com>
From: Ashutosh Sharma <ashu.coek88@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-25T07:28:51Z
Lists: pgsql-hackers
Attachments
- corrected_comments_hash_alloc_buckets_v2.patch (application/x-patch) patch v2
>> While working on - [1], I realised that the following comments in >> _hash_alloc_buckets() needs to be corrected. >> >> /* >> * Initialize the freed overflow page. Just zeroing the page won't work, >> * See _hash_freeovflpage for similar usage. >> */ >> _hash_pageinit(page, BLCKSZ); >> >> Attached is the patch that corrects above comment. Thanks. >> > > - * Initialize the freed overflow page. Just zeroing the page won't work, > + * Initialize the last page in hash index. > > I think saying ".. last page in hash index" sounds slightly awkward as > this is the last page for current split point, how about just > "Initialize the page. ..." Yes, I mean just adding "Initialize the page. ..." looks more simple and correct. Attached is the patch with similar comment.
Commits
-
Fix comment.
- f0a6046bcb15 10.0 landed