Horton

Thread

Commits

  1. Define LDAP_NO_ATTRS if necessary.

  2. Allow custom search filters to be configured for LDAP auth

  1. Getting error message with latest PG source on Windows.

    Ashutosh Sharma <ashu.coek88@gmail.com> — 2017-09-13T08:58:56Z

    Hi,

I am getting the following error message when trying to build latest
PG source on Windows,

Error 1 error C2065: 'LDAP_NO_ATTRS' : undeclared identifier
C:\Users\ashu\pgsql\src\backend\libpq\auth.c 2468

I think, it got introduced in the following git commit,

commit 83aaac41c66959a3ebaec7daadc4885b5f98f561
Author: Peter Eisentraut <peter_e@gmx.net>
Date:   Tue Sep 12 09:46:14 2017 -0400

 Allow custom search filters to be configured for LDAP auth.

Please ignore this email if this issue has already been reported.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

  2. Re: Getting error message with latest PG source on Windows.

    Thomas Munro <thomas.munro@enterprisedb.com> — 2017-09-13T09:11:15Z

    On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> I am getting the following error message when trying to build latest
> PG source on Windows,
>
> Error 1 error C2065: 'LDAP_NO_ATTRS' : undeclared identifier
> C:\Users\ashu\pgsql\src\backend\libpq\auth.c 2468
>
> I think, it got introduced in the following git commit,
>
> commit 83aaac41c66959a3ebaec7daadc4885b5f98f561
> Author: Peter Eisentraut <peter_e@gmx.net>
> Date:   Tue Sep 12 09:46:14 2017 -0400
>
>  Allow custom search filters to be configured for LDAP auth.
>
> Please ignore this email if this issue has already been reported.

Hmm.  LDAP_NO_ATTRS was an addition to the patch discussed here:

https://www.postgresql.org/message-id/7fcac549-0051-34c8-0d62-63b921029f20%402ndquadrant.com

Googling around I see some indications that the macro may not be
defined in all implementations and that some other projects test if
it's defined:

https://github.com/spinn3r/squid-deb/blob/master/squid-2.7.STABLE9/helpers/basic_auth/LDAP/squid_ldap_auth.c#L160

It looks like that's OK because it's required to have the value "1.1":

https://tools.ietf.org/html/rfc4511

      3. A list containing only the OID "1.1" indicates that no
         attributes are to be returned.  If "1.1" is provided with other
         attributeSelector values, the "1.1" attributeSelector is
         ignored.  This OID was chosen because it does not (and can not)
         correspond to any attribute in use.

It seems like we need to do that.

-- 
Thomas Munro
http://www.enterprisedb.com

  3. Re: Getting error message with latest PG source on Windows.

    Thomas Munro <thomas.munro@enterprisedb.com> — 2017-09-13T09:27:06Z

    On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>> I am getting the following error message when trying to build latest
>> PG source on Windows,
>>
>> Error 1 error C2065: 'LDAP_NO_ATTRS' : undeclared identifier
>> C:\Users\ashu\pgsql\src\backend\libpq\auth.c 2468
>
> Googling around I see some indications that the macro may not be
> defined in all implementations and that some other projects test if
> it's defined:

Does this work for you Ashutosh?

-- 
Thomas Munro
http://www.enterprisedb.com

  4. Re: Getting error message with latest PG source on Windows.

    Ashutosh Sharma <ashu.coek88@gmail.com> — 2017-09-13T09:45:36Z

    Hi Thomas,

On Wed, Sep 13, 2017 at 2:57 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>>> I am getting the following error message when trying to build latest
>>> PG source on Windows,
>>>
>>> Error 1 error C2065: 'LDAP_NO_ATTRS' : undeclared identifier
>>> C:\Users\ashu\pgsql\src\backend\libpq\auth.c 2468
>>
>> Googling around I see some indications that the macro may not be
>> defined in all implementations and that some other projects test if
>> it's defined:
>
> Does this work for you Ashutosh?
>
> --

I am currently stuck with some other task on Windows. Is it okay if i
can let you know the results in another 30-40 mins. Thanks.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

  5. Re: Getting error message with latest PG source on Windows.

    Ashutosh Sharma <ashu.coek88@gmail.com> — 2017-09-13T10:39:20Z

    Hi,

On Wed, Sep 13, 2017 at 3:15 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> Hi Thomas,
>
> On Wed, Sep 13, 2017 at 2:57 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro
>> <thomas.munro@enterprisedb.com> wrote:
>>> On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>>>> I am getting the following error message when trying to build latest
>>>> PG source on Windows,
>>>>
>>>> Error 1 error C2065: 'LDAP_NO_ATTRS' : undeclared identifier
>>>> C:\Users\ashu\pgsql\src\backend\libpq\auth.c 2468
>>>
>>> Googling around I see some indications that the macro may not be
>>> defined in all implementations and that some other projects test if
>>> it's defined:
>>
>> Does this work for you Ashutosh?
>>

Thanks for the patch. Yes, it works for me.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

  6. Re: Getting error message with latest PG source on Windows.

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2017-09-13T12:23:40Z

    On 9/13/17 06:39, Ashutosh Sharma wrote:
>>>>> Error 1 error C2065: 'LDAP_NO_ATTRS' : undeclared identifier
>>>>> C:\Users\ashu\pgsql\src\backend\libpq\auth.c 2468
>>>>
>>>> Googling around I see some indications that the macro may not be
>>>> defined in all implementations and that some other projects test if
>>>> it's defined:
>>>
>>> Does this work for you Ashutosh?
>>>
> 
> Thanks for the patch. Yes, it works for me.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services