Re: amcheck support for BRIN indexes

Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>

From: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-08-03T14:37:06Z

Lists: pgsql-hackers

Attachments

v9-0001-brin-refactoring.patch (text/x-patch) patch v9-0001
v9-0004-amcheck-brin_index_check-heap-all-indexed.patch (text/x-patch) patch v9-0004
v9-0003-amcheck-common_verify-register-snapshot-with-indc.patch (text/x-patch) patch v9-0003
v9-0002-amcheck-brin_index_check-index-structure-check.patch (text/x-patch) patch v9-0002

On Fri, Aug 1, 2025 at 11:22 PM Arseniy Mukhin
<arseniy.mukhin.dev@gmail.com> wrote:
>
> Hi,
>
> On Tue, Jul 22, 2025 at 6:43 PM Arseniy Mukhin
> <arseniy.mukhin.dev@gmail.com> wrote:
> >
> > Hi,
> >
> > While reviewing gist amcheck patch [1] I realized that brin amcheck
> > also must check if current snapshot is OK with index indcheckxmin (as
> > btree, gist do it). Currently this check is contained in btree amcheck
> > code, but other AMs need it for heapallindexed as well, so I moved it
> > from btree to verify_common (0003 patch).
>
> There was a compiler warning on CI, so there is a new version with the
> fix (adds #include to verify_common).
> I also moved it to PG19-2.


Sorry for the noise, forgot to attach the files.

Best regards,
Arseniy Mukhin