Re: Recovering from detoast-related catcache invalidations
Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
From: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Noah Misch <noah@leadboat.com>,
Tom Lane <tgl@sss.pgh.pa.us>, Xiaoran Wang <fanfuxiaoran@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-09-29T16:34:47Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix catcache invalidation of a list entry that's being built
- f217c410553d 13.19 landed
- 91fc447c21d3 16.7 landed
- 96e61b2792a5 17.3 landed
- fce17c3a53d6 14.16 landed
- ce7c406f0f8d 15.11 landed
- af8cd1639ab2 18.0 landed
-
Cope with inplace update making catcache stale during TOAST fetch.
- 7a21306aee0a 13.16 landed
- 11f3815d6af8 12.20 landed
- af73e37fa181 14.13 landed
- b08a4b6163eb 15.8 landed
- e4afd7153bd8 16.4 landed
- f9f47f0d93d1 17.0 landed
-
Add previous commit to .git-blame-ignore-revs.
- 36578fa04942 17.0 landed
-
Re-pgindent catcache.c after previous commit.
- d41358f4bbc8 15.6 landed
- d29a4fbacfb7 12.18 landed
- 96c019ffa3f8 17.0 landed
- 7ceeb57baddd 14.11 landed
- 56dcd71decb7 16.2 landed
- 475b3ea3c06b 13.14 landed
-
Cope with catcache entries becoming stale during detoasting.
- db122d426a2d 14.11 landed
- ad98fb14226a 17.0 landed
- 98e03f957436 13.14 landed
- 7e2561e1a258 16.2 landed
- 3b4d85cf159c 12.18 landed
- 2a46a0df4793 15.6 landed
Attachments
- 0001-Add-missed-wait_for_event-in-007_catcache_inval.pl-T.patch.nocfbot (application/octet-stream)
Hi,
On Fri, Sep 19, 2025 at 11:11 PM Andres Freund <andres@anarazel.de> wrote:
>
> On 2025-03-26 07:21:43 -0400, Andres Freund wrote:
> > On 2025-01-14 15:13:21 +0200, Heikki Linnakangas wrote:
> > > Committed with those fixes. Thanks for the review!
> >
> > The test doesn't seem entirely stable. E.g.
> > https://cirrus-ci.com/task/6166374147424256
> > failed spuriously:
> >
> > [08:52:06.822](0.002s) # issuing query 1 via background psql:
> > # SELECT injection_points_set_local();
> > # SELECT injection_points_attach('catcache-list-miss-systable-scan-started', 'wait');
> > [08:52:06.851](0.029s) # results query 1:
> > # {
> > # 'stderr' => 'background_psql: QUERY_SEPARATOR 1:
> > # ',
> > # 'stdout' => '
> > #
> > # background_psql: QUERY_SEPARATOR 1:
> > # '
> > # }
> > [08:52:06.893](0.042s) # issuing query 1 via background psql:
> > # SELECT injection_points_wakeup('catcache-list-miss-systable-scan-started');
> > # SELECT injection_points_detach('catcache-list-miss-systable-scan-started');
> > [08:52:06.897](0.004s) # pump_until: process terminated unexpectedly when searching for "(?^:(^|\n)background_psql: QUERY_SEPARATOR 1:\r?\n)" with stream: ""
> > process ended prematurely at /tmp/cirrus-ci-build/src/test/perl/PostgreSQL/Test/Utils.pm line 440.
> >
> >
> > 2025-03-25 08:52:06.896 UTC [34240][client backend] [007_catcache_inval.pl][4/2:0] ERROR: could not find injection point catcache-list-miss-systable-scan-started to wake up
> > 2025-03-25 08:52:06.896 UTC [34240][client backend] [007_catcache_inval.pl][4/2:0] STATEMENT: SELECT injection_points_wakeup('catcache-list-miss-systable-scan-started');
>
> And again: https://cirrus-ci.com/task/6082321633247232
>
> Ping?
>
The wait_for_event call, which is typically used with a wait injection
point, is missing. Could this be the cause of instability? If this
makes sense, please find the attached fix.
Best regards,
Arseniy Mukhin